Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop shelling out to crictl from kubeadm #3064

Closed
neolit123 opened this issue May 17, 2024 · 3 comments
Closed

stop shelling out to crictl from kubeadm #3064

neolit123 opened this issue May 17, 2024 · 3 comments
Labels
area/cri kind/feature Categorizes issue or PR as related to a new feature. kind/tracking-issue priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.32

Comments

@neolit123
Copy link
Member

neolit123 commented May 17, 2024 •
edited
Loading

instead of shelling out to crictl for CRI actions kubeadm can use the new https://git.k8s.io/cri-client library.

actions

1.31

1.32
@neolit123 neolit123 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. area/cri labels May 17, 2024
@neolit123 neolit123 added this to the v1.31 milestone May 17, 2024
@neolit123 neolit123 mentioned this issue May 17, 2024
Merged
@saschagrunert saschagrunert mentioned this issue May 29, 2024
Merged
saschagrunert added a commit to saschagrunert/release that referenced this issue May 29, 2024
@saschagrunert
Remove kubeadm >=1.32 dependency from crictl
bc7e6ab 
The merge of kubernetes/kubernetes#124685 will
make kubeadm work without crictl. We now reflect that in the packaging
as well as defined in kubernetes/kubeadm#3064.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this issue May 29, 2024
Merged
@neolit123 neolit123 modified the milestones: v1.31, v1.32 Jun 3, 2024
saschagrunert added a commit to saschagrunert/kubernetes that referenced this issue Aug 8, 2024
@saschagrunert
kubeadm: don't warn if crictl binary does not exist
d850fb6 
kubeadm does not rely on `crictl` any more, so we can now drop the
warning in 1.32 as outlined in:

kubernetes/kubeadm#3064

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this issue Aug 8, 2024
Merged
@saschagrunert
Copy link
Member

don't show a warning/error if the crictl binary is missing on kubeadm preflight

This should be addressed with kubernetes/kubernetes#126596

@saschagrunert
Copy link
Member

@neolit123 can we close this one?

@neolit123
Copy link
Member Author

yes, closing. thanks!

hungnguyen243 pushed a commit to hungnguyen243/kubernetes that referenced this issue Aug 16, 2024
@saschagrunert @hungnguyen243
kubeadm: don't warn if crictl binary does not exist
6012772 
kubeadm does not rely on `crictl` any more, so we can now drop the
warning in 1.32 as outlined in:

kubernetes/kubeadm#3064

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
SoulPancake pushed a commit to SoulPancake/k8s that referenced this issue Sep 11, 2024
@saschagrunert @SoulPancake
kubeadm: don't warn if crictl binary does not exist
d64db25 
kubeadm does not rely on `crictl` any more, so we can now drop the
warning in 1.32 as outlined in:

kubernetes/kubeadm#3064

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cri kind/feature Categorizes issue or PR as related to a new feature. kind/tracking-issue priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.32
Development

No branches or pull requests
2 participants
@neolit123 @saschagrunert