Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[failing test] kubeadm-kinder-control-plane-kubelet-local-mode-latest "upgrade diff" action failing #3110

Closed
neolit123 opened this issue Sep 12, 2024 · 4 comments · Fixed by kubernetes/kubernetes#127315
Closed

[failing test] kubeadm-kinder-control-plane-kubelet-local-mode-latest "upgrade diff" action failing #3110

neolit123 opened this issue Sep 12, 2024 · 4 comments · Fixed by kubernetes/kubernetes#127315
Assignees
@neolit123
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.32

Comments

@neolit123
Copy link
Member

after the recent changes for upgrade phases, the https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-control-plane-kubelet-local-mode-latest test continue to be red.

the failure seems to be


kinder-control-plane-local-kubelet-mode-control-plane-1:$ kubeadm upgrade diff --v=6 --config /kind/kubeadm.conf
time="08:08:14" level=debug msg="Running: docker exec kinder-control-plane-local-kubelet-mode-control-plane-1 kubeadm upgrade diff --v=6 --config /kind/kubeadm.conf"
empty manifest path
k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade.validateManifestsPath
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade/diff.go:92
k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade.newCmdDiff.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade/diff.go:69
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/cobra@v1.8.1/command.go:985
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/cobra@v1.8.1/command.go:1117
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/cobra@v1.8.1/command.go:1041
k8s.io/kubernetes/cmd/kubeadm/app.Run
	k8s.io/kubernetes/cmd/kubeadm/app/kubeadm.go:47
main.main
	k8s.io/kubernetes/cmd/kubeadm/kubeadm.go:25
runtime.main
	runtime/proc.go:272
runtime.goexit
	runtime/asm_amd64.s:1700
Error: failed to exec action kubeadm-upgrade: exit status 1
 exit status 1

https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-kinder-control-plane-kubelet-local-mode-latest/1834140259051376640/build-log.txt
@neolit123 neolit123 added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Sep 12, 2024
@neolit123 neolit123 added this to the v1.32 milestone Sep 12, 2024
@neolit123
Copy link
Member Author

i think this might be due to kubernetes/kubernetes@d62b797

@SataQiu
Copy link
Member

SataQiu commented Sep 12, 2024 •
edited
Loading

Yes, we should also update here.

	if err := validateManifestsPath(
		flags.apiServerManifestPath,
		flags.controllerManagerManifestPath,
		flags.schedulerManifestPath); err != nil {
		return err
	}

https://github.com/kubernetes/kubernetes/blob/d589a3f866144087e19d092a63b2ef275f2ab912/cmd/kubeadm/app/cmd/upgrade/diff.go#L70-L73

@neolit123
Copy link
Member Author

/assign
will send PR soon

@neolit123 neolit123 mentioned this issue Sep 12, 2024
Merged
@neolit123
Copy link
Member Author

fix is here

tested it locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.32
Development

Successfully merging a pull request may close this issue.

kubeadm: add default paths to 'upgrade diff' neolit123/kubernetes
2 participants
@neolit123 @SataQiu