Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start utilizing kubectl genericclioptions #959

Closed
luxas opened this issue Jun 29, 2018 · 5 comments
Closed

Start utilizing kubectl genericclioptions #959

luxas opened this issue Jun 29, 2018 · 5 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@luxas
Copy link
Member

luxas commented Jun 29, 2018

ref: kubernetes/enhancements#581

As part of ongoing work that focuses on containing all significant kubectl command utilities in a single package (pkg/kubectl/genericclioptions), this package should be split out into its own repo in order to allow use by third-party clients as well as plugins. The self-contained genericclioptions package currently provides all of the major components (kubeconfig parsing, obtaining a config and a REST client, printing, etc.) needed to build a generic kubectl command. Making this package into a separate repository would allow external plugins to behave and be structured as a typical kubectl command, particularly in terms of communicating with the api server.

@luxas luxas added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 29, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2018
@neolit123
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2018
@timothysc timothysc added this to the Next milestone Jan 7, 2019
@timothysc timothysc added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 7, 2019
@neolit123
Copy link
Member

there are a lot of PR in k/k the past few weeks moving things out to staging.

but we might need better detail to outline what can actually be used.

The self-contained genericclioptions package currently provides all of the major components (kubeconfig parsing, obtaining a config and a REST client, printing, etc.) needed to build a generic kubectl command

for most things we already use client-go, printing of e.g. runtime objects is nice and it we might use it for the machine readable output work.

@neolit123
Copy link
Member

most of the kubectl backend is now in staging.
as part of the future work around the "kubeadm library" we could evaluate what can be reused:
#2316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants