From 908e806ca17b4004d935ec20946f207a1f7d65a9 Mon Sep 17 00:00:00 2001 From: Sascha Grunert Date: Wed, 11 Sep 2024 14:05:51 +0200 Subject: [PATCH] Remove ACL ownership change on release publish Signed-off-by: Sascha Grunert --- pkg/release/publish.go | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/pkg/release/publish.go b/pkg/release/publish.go index 03fefd5235c..3a7b001d4af 100644 --- a/pkg/release/publish.go +++ b/pkg/release/publish.go @@ -371,25 +371,6 @@ func (p *Publisher) PublishToGcs( var content string if !privateBucket { - // New Kubernetes infra buckets, like k8s-staging-kubernetes, have a - // bucket-only ACL policy set, which means attempting to set the ACL on - // an object will fail. We should skip this ACL change in those - // instances, as new buckets already default to being publicly - // readable. - // - // Ref: - // - https://cloud.google.com/storage/docs/bucket-policy-only - // - https://github.com/kubernetes/release/issues/904 - if !strings.HasPrefix(markerPath, object.GcsPrefix+"k8s-") { - aclOutput, err := p.client.GSUtilOutput( - "acl", "ch", "-R", "-g", "all:R", publishFileDst, - ) - if err != nil { - return fmt.Errorf("change %s permissions: %w", publishFileDst, err) - } - logrus.Infof("Making uploaded version file public: %s", aclOutput) - } - // If public, validate public link response, err := p.client.GetURLResponse(publicLink) if err != nil {