Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub AppID and key authentication to commenter bot #32805

Open
tnozicka opened this issue Jun 21, 2024 · 4 comments · May be fixed by #32806
Open

Add GitHub AppID and key authentication to commenter bot #32805

tnozicka opened this issue Jun 21, 2024 · 4 comments · May be fixed by #32806
Assignees
@tnozicka
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@tnozicka
Copy link
Contributor

What would you like to be added:
I'd like to extend the commenter robot flags, so it can be used with GitHub AppID credentials.

(I understand that GitHub apps can authenticate only for a single installation ID, so the queries will be limited to single org, if such authentication option is used.)

Why is this needed:
The commenter robot accepts only GH token for authentication. This is problematic because it needs a real GH user which will incur additional cost for organizations. More importantly, I have tried creating such account and generating long-lived access token for it in "Developer options" but even with --ceiling=10 and the job run every hour, it got flagged by GitHub after the first run(s) which made its comments invisible to anyone else. My hope it using the GitHub App avoids these bans and is similar to native GitHub workflows that get the automatic token.

/assign
@tnozicka tnozicka added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 21, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 21, 2024
@tnozicka
Copy link
Contributor Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2024
@tnozicka tnozicka linked a pull request Jun 21, 2024 that will close this issue
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 19, 2024
@tnozicka
Copy link
Contributor Author

tnozicka commented Oct 21, 2024 •
edited
Loading

/remove-lifecycle rotten
/triage accepted
(I'll try to get back to the PR soon)

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnozicka tnozicka

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wire in GitHub App authentication for the commenter and update job flags tnozicka/test-infra
3 participants
@tnozicka @k8s-ci-robot @k8s-triage-robot