Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove capdo lint job in favor of gh actions and update owners file for capdo #30627

Merged
merged 2 commits into from
Sep 6, 2023
Merged

remove capdo lint job in favor of gh actions and update owners file for capdo #30627

merged 2 commits into from
Sep 6, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 6, 2023 •
edited
Loading

  • remove capdo lint job in favor of gh actions
  • update owners file for capdo

xref: kubernetes-sigs/cluster-api-provider-digitalocean#517

/assign @gottwald @timoreimann

@cpanato
remove capdo lint job in favor of gh actions
9a0c4e9 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
update owners file for capdo
245f89a 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 6, 2023
@cpanato cpanato closed this Sep 6, 2023
@cpanato cpanato reopened this Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, timoreimann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b36a5b3 into kubernetes:master Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-digitalocean-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-digitalocean/cluster-api-provider-digitalocean-presubmits.yaml

In response to this:

  • remove capdo lint job in favor of gh actions
  • update owners file for capdo

xref: kubernetes-sigs/cluster-api-provider-digitalocean#517

/assign @gottwald @timoreimann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the update-capdo branch September 6, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann approved these changes

@prksu prksu Awaiting requested review from prksu

Assignees

@timoreimann timoreimann

@gottwald gottwald

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpanato @k8s-ci-robot @timoreimann @gottwald