Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch logs destination from kubernetes-jenkins to kubernetes-ci-logs #33611

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Switch logs destination from kubernetes-jenkins to kubernetes-ci-logs #33611

merged 1 commit into from
Oct 11, 2024

Conversation

dims
Copy link
Member

@dims dims commented Oct 9, 2024 •
edited
Loading

Follow up to https://kubernetes.slack.com/archives/C09QZ4DQB/p1728496841405889

Switch jobs to send logs to the new bucket as the old one will go away

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 9, 2024
@dims
Copy link
Member Author

dims commented Oct 9, 2024

we are already syncing the buckets.. https://kubernetes.slack.com/archives/C09QZ4DQB/p1728501367176459?thread_ts=1728496841.405889&cid=C09QZ4DQB

/hold cancel

@dims dims force-pushed the switch-logs-destination-from-kubernetes-jenkins-to-kubernetes-ci-logs branch from f0d4145 to 5c58408 Compare October 9, 2024 19:19
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Oct 9, 2024
@krzyzacy
Copy link
Member

/cc @BenTheElder

@dims dims changed the title [WIP] Switch logs destination from kubernetes-jenkins to kubernetes-ci-logs Switch logs destination from kubernetes-jenkins to kubernetes-ci-logs Oct 11, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
michelle192837
michelle192837 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@michelle192837 michelle192837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I'll unhold once I confirm that the current sync from kubernetes-jenkins to kubernetes-ci-logs completes, and I've paused it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@michelle192837
Copy link
Contributor

Ref: #33381

michelle192837
michelle192837 reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@michelle192837 michelle192837 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: (ETA: job_url_template in config/prow/config.yaml) I think this should also be kubernetes-ci-logs if I understand it correctly?

@dims dims force-pushed the switch-logs-destination-from-kubernetes-jenkins-to-kubernetes-ci-logs branch from 5c58408 to 0b24c17 Compare October 11, 2024 19:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@dims
Copy link
Member Author

dims commented Oct 11, 2024

Done!

@michelle192837
Copy link
Contributor

Awesome, thanks!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@dims
Copy link
Member Author

dims commented Oct 11, 2024

looks like legit test errors. digging in

@dims
Switch logs destination from kubernetes-jenkins to kubernetes-ci-logs
fca6e2e 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the switch-logs-destination-from-kubernetes-jenkins-to-kubernetes-ci-logs branch from 0b24c17 to fca6e2e Compare October 11, 2024 20:24
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dims,michelle192837]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 035e4f9 into kubernetes:master Oct 11, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

Follow up to https://kubernetes.slack.com/archives/C09QZ4DQB/p1728496841405889

Switch jobs to send logs to the new bucket as the old one will go away

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@upodroid upodroid mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 michelle192837 approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@michelle192837 michelle192837

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @krzyzacy @michelle192837 @k8s-ci-robot