-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct main branch in image publishing of external-snapshot-metadata #33700
base: master
Are you sure you want to change the base?
Use correct main branch in image publishing of external-snapshot-metadata #33700
Conversation
Hi @hairyhum. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hairyhum The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @xing-yang @Rakshith-R |
@hairyhum: GitHub didn't allow me to assign the following users: Rakshith-R. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one more place that needs the same change.
- ^master$ |
Hmm, we have a problem here. This is an auto-generated file. |
You'll need to modify gen-jobs.sh to automatically set it to "main" for external-snapshot-metadata: https://github.com/kubernetes/test-infra/pull/33303/files#diff-a8e1d6d57695368eeaaf2c7b80d75ce59078cea09d2218469a6a5dc7009dc8f5 |
New repos like `external-snapshot-metadata` are using `main` branch instead of `master`.
b072da3
to
96376be
Compare
@xing-yang @Rakshith-R updated the template and re-generated. |
This will break jobs for all other sidecars. |
Follow-up to #33303
Addressing #33303 (comment)