Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StatefulSetStartOrdinal feature gate to target stable in 1.31 #46719

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Remove StatefulSetStartOrdinal feature gate to target stable in 1.31 #46719

merged 1 commit into from
Jul 24, 2024

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented Jun 7, 2024 •
edited
Loading

Remove StatefulSetStartOrdinal feature gate to target stable in 1.31

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2024
@pwschuurman pwschuurman mentioned this pull request Jun 7, 2024
Open
17 tasks
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 7, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 7, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c5205da
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/668c9116d72812000826dfa7
😎 Deploy Preview https://deploy-preview-46719--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Jun 7, 2024

Please check your commit for auto-generated contents. Those pages are not supposed to be manually updated.

dipesh-rawat
dipesh-rawat reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwschuurman, We should consider setting the dev-1.31 branch as the target branch rather than the main branch for this pull request. Since the change is related to the feature targeting stable in 1.31.

sftim
sftim reviewed Jun 7, 2024
View reviewed changes
content/en/docs/concepts/workloads/controllers/statefulset.md Outdated
@@ -178,13 +178,11 @@ will also add a pod label with this index: `apps.kubernetes.io/pod-index`.

### Start ordinal

{{< feature-state for_k8s_version="v1.27" state="beta" >}}
{{< feature-state for_k8s_version="v1.31" state="stable" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

Suggested change
{{< feature-state for_k8s_version="v1.31" state="stable" >}}
{{< feature-state feature_gate_name="StatefulSetStartOrdinal" >}}

which auto updates, and is our current good practice.

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2024
@pwschuurman pwschuurman changed the base branch from main to dev-1.31 July 9, 2024 01:23
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 9, 2024
@pwschuurman
Copy link
Contributor Author

@pwschuurman, We should consider setting the dev-1.31 branch as the target branch rather than the main branch for this pull request. Since the change is related to the feature targeting stable in 1.31.

Thanks, updated to dev-1.31 branch.

@tengqm
Copy link
Contributor

tengqm commented Jul 9, 2024

/hold
The upstream change is not merged yet.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2024
@pwschuurman
Copy link
Contributor Author

Hi @tengqm, the upstream change kubernetes/kubernetes#125374 has been merged.

@tengqm
Copy link
Contributor

tengqm commented Jul 23, 2024

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
mengjiao-liu
mengjiao-liu reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@mengjiao-liu mengjiao-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc113387bce8e78937dbeed135c4ed6367cd5541

@k8s-ci-robot k8s-ci-robot merged commit 22b1bd0 into kubernetes:dev-1.31 Jul 24, 2024
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@sftim sftim sftim left review comments

@mengjiao-liu mengjiao-liu mengjiao-liu left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mengjiao-liu mengjiao-liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@pwschuurman @tengqm @k8s-ci-robot @dipesh-rawat @sftim @mengjiao-liu