Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ru] remove extra tags in KubeCon section #48550

Closed
wants to merge 1 commit into from

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Oct 26, 2024

Description

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from arhell. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/ru Issues or PRs related to Russian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2024
Copy link

netlify bot commented Oct 26, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6c62d7d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/671c9273c1596a0008ac998d
😎 Deploy Preview https://deploy-preview-48550--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Oct 28, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the preview page (here), the changes look good to me.
/lgtm

Fixed 'ru' Homepage | Current 'ru' Homepage

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a31baa219ed901b58586670481539ac8fbbfb9a

@shurup
Copy link
Member

shurup commented Oct 28, 2024

It was me who put those extra <br>'s. Now, I realise there's a problem due to this page being rendered differently in different browsers.

Here's an updated version as offered in this PR rendered in Chrome/Linux. Looks good:
image

But here's what will happen in Firefox/Linux (which I use by default). Doesn't look good:
image

I need to think about what can be done to avoid this in Firefox after we remove extra <br>'s.

Copy link
Member Author

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close

@Arhell Arhell closed this Oct 28, 2024
@Arhell Arhell deleted the ru-remove branch October 28, 2024 06:27
@shurup
Copy link
Member

shurup commented Oct 28, 2024

According to my current experiments, it has something to do with the fonts. If we use a smaller font (15px instead of 18px) or a bigger line-height (e.g. 1.8 instead of 1.5) in the Russian version, everything works fine. To conclude, it looks like different fonts are used or they are rendered differently (for the Russian version). Someone with good, relevant experience (CSS for Firefox) is needed to solve this.

@Arhell
Copy link
Member Author

Arhell commented Oct 28, 2024

According to my current experiments, it has something to do with the fonts. If we use a smaller font (15px instead of 18px) or a bigger line-height (e.g. 1.8 instead of 1.5) in the Russian version, everything works fine. To conclude, it looks like different fonts are used or they are rendered differently (for the Russian version). Someone with good, relevant experience (CSS for Firefox) is needed to solve this.

Good solution, but in my opinion I would redo this section as a whole.

@shurup
Copy link
Member

shurup commented Oct 28, 2024

in my opinion I would redo this section as a whole.

I would definitely support this! It started a while ago with fewer conferences/buttons in place. Later, it hasn't evolved well enough to handle current needs. It should be fixed in the original (English) version first then.

@shurup
Copy link
Member

shurup commented Dec 20, 2024

JFYI: #49167 should resolve the issue we've discussed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ru Issues or PRs related to Russian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants