Redesign KubeCon links on the main page #49167
Open
+17
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Shurupov <dmitry.shurupov@palark.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NameNoQuality The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm suggesting this redesign of the "Attend KubeCon…" block on the main page (see After):
In my understanding, it's needed since we have five KubeCons now, and adding more huge buttons (as we did before — see Before) won't really work anymore.
While working on this design improvement, I've also noticed a long-standing HTML bug since we had such entities for the KubeCon links for many years:
<a href="..." button id="desktopKCButton">. They are not valid for two reasons: a) the<a>tag does not have thebuttonattribute, and b) we can't use the sameidfor numerous HTML objects on the same page. Thus, I removed thebuttonattribute and converteddesktopKCButtonfromidtoclass.Obviously, I've also synced the actual KubeCon events (links & dates) with the upcoming 2025 events.
I've checked how the suggested changes are rendered in two browsers (Firefox and Chrome in Linux). However, more testing, as well as general feedback, will be very much appreciated.