From 2af5dab6aad14601571a9c40e124b94eaeedb28b Mon Sep 17 00:00:00 2001 From: Vaidas Jablonskis Date: Tue, 27 Feb 2024 12:35:00 +0200 Subject: [PATCH] test/e2e: ensure there is no error waiting for instance --- test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go b/test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go index ca7e1fe41..9ef82012d 100644 --- a/test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go +++ b/test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go @@ -363,6 +363,7 @@ func TestCloudSlackE2E(t *testing.T) { return strings.Contains(msg, fmt.Sprintf("Botkube instance %q is now active.", deployment.Name)), 0, "" } err = tester.WaitForMessagePosted(tester.BotUserID(), channel.ID(), 3, assertionFn) + require.NoError(t, err) cmdHeader := func(command string) string { return fmt.Sprintf("`%s` on `%s`", command, deployment.Name) @@ -456,7 +457,7 @@ func TestCloudSlackE2E(t *testing.T) { fmt.Sprintf("The 'latest' tag used in 'nginx:latest' image of Pod '%s/%s' container 'nginx' should be avoided.", pod.Namespace, pod.Name), } - var result = true + result := true for _, str := range expStrings { if !strings.Contains(msg, str) { result = false @@ -688,7 +689,7 @@ func screenshotIfShould(t *testing.T, cfg E2ESlackConfig, page *rod.Page) { return } - err = os.WriteFile(filePath, data, 0644) + err = os.WriteFile(filePath, data, 0o644) assert.NoError(t, err) }