Revert "Add temporary workflow to test e2e tests"

This reverts commit 7ab399d.
kubeshop · Jun 19, 2024 · 88b522a · 88b522a
1 parent 778115e
commit 88b522a
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 64 deletions.
diff --git a/.github/actions/cloud-slack-e2e/action.yaml b/.github/actions/cloud-slack-e2e/action.yaml
@@ -123,15 +123,15 @@ runs:
 
         echo "footer=${FOOTER}" >> $GITHUB_OUTPUT
 
-#    - name: Slack Notification
-#      uses: rtCamp/action-slack-notify@v2
-#      if: ${{ failure() }}
-#      env:
-#        SLACK_CHANNEL: 'botkube-cloud-ci-alerts'
-#        SLACK_USERNAME: Botkube Cloud CI
-#        SLACK_COLOR: 'red'
-#        SLACK_TITLE: 'Message'
-#        SLACK_MESSAGE: "Cloud Slack ${{ inputs.e2e_type }} E2E tests failed :scream:"
-#        SLACK_ICON_EMOJI: ':this-is-fine-fire:'
-#        SLACK_FOOTER: ${{ steps.footer.outputs.footer }}
-#        SLACK_WEBHOOK: ${{ inputs.slack_alerts_webhook }}
+    - name: Slack Notification
+      uses: rtCamp/action-slack-notify@v2
+      if: ${{ failure() }}
+      env:
+        SLACK_CHANNEL: 'botkube-cloud-ci-alerts'
+        SLACK_USERNAME: Botkube Cloud CI
+        SLACK_COLOR: 'red'
+        SLACK_TITLE: 'Message'
+        SLACK_MESSAGE: "Cloud Slack ${{ inputs.e2e_type }} E2E tests failed :scream:"
+        SLACK_ICON_EMOJI: ':this-is-fine-fire:'
+        SLACK_FOOTER: ${{ steps.footer.outputs.footer }}
+        SLACK_WEBHOOK: ${{ inputs.slack_alerts_webhook }}
diff --git a/.github/workflows/test-ui-e2e-tests.yml b/.github/workflows/test-ui-e2e-tests.yml
diff --git a/test/cloud-slack-dev-e2e/botkube_page_helpers_test.go b/test/cloud-slack-dev-e2e/botkube_page_helpers_test.go
@@ -131,7 +131,6 @@ func (p *BotkubeCloudPage) OpenSlackAppIntegrationPage(t *testing.T) {
 
 // ReAddSlackPlatformIfShould add the slack platform again as the page was often not refreshed with a newly connected Slack Workspace.
 // It only occurs with headless mode.
-// TODO(@pkosiec): Do you have a better idea how to fix it?
 func (p *BotkubeCloudPage) ReAddSlackPlatformIfShould(t *testing.T, isHeadless bool) {
 	if !isHeadless {
 		return

diff --git a/test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go b/test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go
@@ -77,8 +77,9 @@ func TestCloudSlackE2E(t *testing.T) {
 	err := envconfig.Init(&cfg)
 	require.NoError(t, err)
 
-	cfg.Slack.Tester.CloudBasedTestEnabled = false // override property used only in the Cloud Slack E2E tests
-	cfg.Slack.Tester.RecentMessagesLimit = 3       // this is used effectively only for the Botkube restarts. There are two of them in a short time window, so it shouldn't be higher than 5.
+	cfg.Slack.Tester.CloudBasedTestEnabled = false        // override property used only in the Cloud Slack E2E tests
+	cfg.Slack.Tester.RecentMessagesLimit = 3              // this is used effectively only for the Botkube restarts. There are two of them in a short time window, so it shouldn't be higher than 5.
+	cfg.Slack.Tester.MessageWaitTimeout = 3 * time.Minute // downloading plugins on restarted Agents, sometimes takes a while on GitHub runners.
 
 	var botkubeDeploymentUninstalled atomic.Bool
 	botkubeDeploymentUninstalled.Store(true) // not yet installed