-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to install Botkube via CLI, add --verbose
flag
#1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
cli/add-install
branch
2 times, most recently
from
July 10, 2023 17:54
096f50e
to
db6a62f
Compare
mszostok
force-pushed
the
cli/add-install
branch
2 times, most recently
from
July 11, 2023 13:03
60517fe
to
9ce9fcd
Compare
huseyinbabal
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot's of improvements, thank you 🚀
mszostok
force-pushed
the
cli/add-install
branch
from
July 12, 2023 16:39
9ce9fcd
to
71706b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
- use Helm Go SDK underneath to install the chart
- make sure it can be run with debug/verbose
- support dry-run
- support Botkube version and overrides
- Respect KUBECONFIG env variable
--verbose
flag--verbose=trace
is used. It should be useful to print it only if needed, as printing that all the time could be too messy.Testing
here are described all
install
flags: https://github.com/kubeshop/botkube/blob/db6a62fcce7dee3856827fa05a32971e837c400f/cmd/cli/docs/botkube_install.mdScreen.Recording.2023-07-10.at.23.42.15.mov
Notes
In the next PR I will add streaming Botkube Pod logs. This PR is already huge and I'm still working on logs.
Related issue(s)
install
command to Botkube CLI #1133