Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename x plugin to exec #1137

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Rename x plugin to exec #1137

merged 2 commits into from
Jul 12, 2023

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jul 12, 2023

Description

Changes proposed in this pull request:

  • Rename x plugin to exec

Testing

  1. Create k3d cluster: k3d cluster create labs --image=rancher/k3s:v1.25.0-k3s1

  2. Start plugin server: env PLUGIN_SERVER_HOST=http://host.k3d.internal go run test/helpers/plugin_server.go

  3. Build x plugin: PLUGIN_TARGETS="exec" make build-plugins

  4. Install Botkube with such example config:

    config yaml

    communications:
      default-group:
        socketSlack:
          enabled: true
          channels:
            default:
              name: general
              bindings:
                sources: [ ]
                executors:
                  - bins-management
          appToken: "xapp-1"
          botToken: "xoxb-"
    
    executors:
      bins-management:
        local-repo/exec:
          enabled: true
          context:
            rbac:
              group:
                type: Static
                static:
                  values: [ "system:masters" ]
          config:
            templates:
              - ref: github.com/mszostok/botkube//cmd/executor/x/templates?ref=rename-x
    
    plugins:
      repositories:
        local-repo:
          url: http://host.k3d.internal:3000/botkube.yaml
    
    settings:
      log:
        level: "debug"
      clusterName: "labs"
      upgradeNotifier: false
    
    analytics:
      disable: true
    
    configWatcher:
      enabled: false

  • Then try to play with:
    Botkube x install https://get.helm.sh/helm-v3.10.3-darwin-amd64.tar.gz --file helm
    
    • check quick start
    • typing command directly
    • using x run helm list -A and see play with interactive message

Related issue(s)

Fix #1111

@mszostok mszostok marked this pull request as ready for review July 12, 2023 10:52
@mszostok mszostok requested review from a team and PrasadG193 as code owners July 12, 2023 10:52
@mszostok mszostok requested review from huseyinbabal and pkosiec and removed request for huseyinbabal July 12, 2023 10:52
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mszostok mszostok enabled auto-merge (squash) July 12, 2023 11:00
@mszostok mszostok merged commit fd300da into kubeshop:main Jul 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribute X plugin
2 participants