Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --auto-upgrade to --auto-approve flag for Migration CLI #1149

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Jul 17, 2023

Description

Changes proposed in this pull request:

  • Rename --auto-upgrade to --auto-approve flag for Migration CLI

Just to unify the flags as install uses this 👍

@pkosiec pkosiec requested review from a team and PrasadG193 as code owners July 17, 2023 08:22
@pkosiec pkosiec requested a review from mszostok July 17, 2023 08:22
@pkosiec pkosiec changed the title Unify auto-approve flag for Migration CLI Rename --auto-upgrade to --auto-approve flag for Migration CLI Jul 17, 2023
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkosiec pkosiec merged commit 3a5f715 into kubeshop:main Jul 17, 2023
13 checks passed
@pkosiec pkosiec deleted the unify-flags branch July 17, 2023 08:38
mszostok added a commit that referenced this pull request Jul 17, 2023
* Fix brew release, add windows, use binary format (#1144)

* Add build flags to CLI (#1146)

* Plugins logger respect generic logger settings (#1147)

* Add timestamp annotation on update (#1148)

* Rename `--auto-upgrade` to `--auto-approve` flag for Migration CLI (#1149)

* Unify auto-approve flag for Migration CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants