Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pkg imported more than once #1153

Merged
merged 1 commit into from
Jul 19, 2023
Merged

chore: pkg imported more than once #1153

merged 1 commit into from
Jul 19, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Jul 18, 2023 •
edited
Loading

Description

package "github.com/charmbracelet/log" is being imported more than once

  • ...

Testing

Related issue(s)

@testwill testwill requested review from a team and PrasadG193 as code owners July 18, 2023 08:00
@testwill testwill requested a review from pkosiec July 18, 2023 08:00
@pkosiec pkosiec added the refactor Code refactoring. No functional changes label Jul 19, 2023
pkosiec
pkosiec approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@pkosiec pkosiec merged commit d413cef into kubeshop:main Jul 19, 2023
13 checks passed
@testwill testwill deleted the pkg branch July 20, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
refactor Code refactoring. No functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testwill @pkosiec