Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doctor plugin schema #1161

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

madebyrogal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • change doctor plugin schema 04 to 07
  • change plugin server port 3000 -> 3010 cos 3000 is usually used by react and conflicts with local UI (this is a proposal)

Testing

Related issue(s)

@madebyrogal madebyrogal requested review from a team and PrasadG193 as code owners July 21, 2023 14:51
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update helm doc: https://github.com/kubeshop/botkube/blame/main/cmd/executor/helm/README.md#L48 with the port change 👍 Thanks!

test/helpers/plugin_server.go Outdated Show resolved Hide resolved
@mszostok mszostok added the bug Something isn't working label Jul 24, 2023
@mszostok mszostok added this to the v1.3.0 milestone Jul 24, 2023
@madebyrogal madebyrogal merged commit ea69b68 into kubeshop:main Jul 27, 2023
13 checks passed
@madebyrogal madebyrogal deleted the fix-doctor-plugin-schema branch July 27, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants