Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of prod tests, add missing error assertions #1411

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Reduce number of prod tests, add missing error assertions #1411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af6b6da
Reduce number of prod tests, add missing error assertions
pkosiec Mar 11, 2024
d6e368d
Run prod tests every 4 hours
pkosiec Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/branch-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,14 +268,6 @@ jobs:
run: |
KUBECONFIG=$(k3d kubeconfig write cli-migration-e2e-cluster) make test-cli-migration-e2e

- name: Upload artifacts
pkosiec marked this conversation as resolved.
Show resolved Hide resolved
uses: actions/upload-artifact@v4
if: ${{ always() }}
with:
name: screenshots_dump_${{github.sha}}
path: ${{ runner.temp }}/screenshots
retention-days: 5

- name: Dump cluster state
if: ${{ failure() }}
uses: ./.github/actions/dump-cluster
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prod-e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Botkube Cloud Prod E2E test
on:
workflow_dispatch:
schedule:
- cron: "0 */1 * * *" # Every 1 hour
- cron: "0 */4 * * *" # Every 4 hours

env:
HELM_VERSION: v3.9.0
Expand Down
4 changes: 3 additions & 1 deletion test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ func TestCloudSlackE2E(t *testing.T) {
_, err := shortBkTimeoutPage.ElementR(".ant-layout-content p", "All Botkube installations managed by Botkube Cloud.")
if err != nil {
t.Logf("Failed to detect homepage with other instances created: %v", err)
// Case 2:
// Fallback to Case 2: No other instances created
t.Logf("Checking if the homepage is in the 'no instances' state...")
_, err := botkubePage.ElementR(".ant-layout-content h2", "Create your Botkube instance!")
assert.NoError(t, err)
Expand Down Expand Up @@ -363,6 +363,7 @@ func TestCloudSlackE2E(t *testing.T) {
return strings.Contains(msg, fmt.Sprintf("Botkube instance %q is now active.", deployment.Name)), 0, ""
}
err = tester.WaitForMessagePosted(tester.BotUserID(), channel.ID(), 3, assertionFn)
require.NoError(t, err)

cmdHeader := func(command string) string {
return fmt.Sprintf("`%s` on `%s`", command, deployment.Name)
Expand Down Expand Up @@ -489,6 +490,7 @@ func TestCloudSlackE2E(t *testing.T) {
}
return true, 0, ""
})
require.NoError(t, err)

t.Log("Verifying disabled notification on Cloud...")
deploy := gqlCli.MustGetDeployment(t, graphql.ID(deployment.ID))
Expand Down
Loading