Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: add cluster scan help docs #1451

Merged
merged 1 commit into from
May 28, 2024
Merged

bot: add cluster scan help docs #1451

merged 1 commit into from
May 28, 2024

Conversation

vaijab
Copy link
Collaborator

@vaijab vaijab commented May 28, 2024

Description

Part of https://github.com/kubeshop/botkube-cloud/issues/1062

Changes proposed in this pull request:

  • bot: add cluster scan help docs

Testing

Related issue(s)

@vaijab vaijab requested review from PrasadG193 and a team as code owners May 28, 2024 07:11
@vaijab vaijab requested review from madebyrogal and pkosiec and removed request for madebyrogal May 28, 2024 07:11
@vaijab vaijab added the documentation Documetation is missing or incorrect label May 28, 2024
Comment on lines 214 to 215
Buttons: []api.Button{
h.btnBuilder.ForCommandWithoutDesc("Ask a question", "ai hi!", api.ButtonStylePrimary),
h.btnBuilder.ForCommandWithoutDesc("Cluster Scan", "ai scan", api.ButtonStylePrimary),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check with @miklosp if we should have these two lines. IMO the Ask a question button is quite unnecessary and as now we have a very useful command, we could keep a single button.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miklosp please advise.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
updated with suggested changes.

Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd wait for @miklosp for final confirmation 👍

image

@vaijab vaijab merged commit aca7405 into main May 28, 2024
20 checks passed
@vaijab vaijab deleted the clusterscan branch May 28, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documetation is missing or incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants