Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send ack when the new cfg 'resourceVersion' was loaded without restart #1455

Closed
wants to merge 2 commits into from
Closed

Send ack when the new cfg 'resourceVersion' was loaded without restart #1455

wants to merge 2 commits into from

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jun 12, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Send ack when the new cfg 'resourceVersion' was loaded without restart

Testing

  1. Create new Instance
  2. Deploy Agent v1.12
  3. Update plugin without making any changes
  4. See that it stuck in 'Updating' phase
  5. Redeploy Agent with the PR image by adding: 
    --set settings.log.level="debug
--set image.repository=kubeshop/pr/botkube
  6. Again, to the plugin update without making any changes
  7. See that Agent transition to 'Connected' within 1min

To see the logs you need to have kubectl set env deployment/botkube BOTKUBE_SETTINGS_LOG_LEVEL="debug"

Screen.Recording.2024-06-12.at.15.51.16.mov

Related issue(s)

Fix https://github.com/kubeshop/botkube-cloud/issues/1127

@mszostok mszostok added the enhancement New feature or request label Jun 12, 2024
@mszostok mszostok force-pushed the add-connect-report branch 2 times, most recently from 2750983 to 6a526b7 Compare June 12, 2024 13:42
@mszostok mszostok marked this pull request as ready for review June 12, 2024 13:55
@mszostok mszostok requested review from PrasadG193 and a team as code owners June 12, 2024 13:55
@mszostok mszostok requested a review from vaijab June 12, 2024 13:55
vaijab
vaijab approved these changes Jun 13, 2024
View reviewed changes
cmd/botkube-agent/main.go Show resolved Hide resolved
@mszostok mszostok force-pushed the add-connect-report branch 2 times, most recently from e36772c to 4eb6d6b Compare June 14, 2024 13:03
@mszostok
Copy link
Contributor Author

This introduces instability in the team's tests, so for now, I have put it on hold.

@mszostok mszostok closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaijab vaijab vaijab approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @vaijab