Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid checking for latest release on GitHub with every CLI command #6019

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: avoid checking for latest release on GitHub with every CLI command #6019

merged 1 commit into from
Nov 12, 2024

Conversation

rangoo94
Copy link
Member

Pull request description

  • Docker Init command was fetching the latest version before it was needed, just to populate the docs
    • Because of that, every testkube command was fetching the latest version from GitHub too
    • Most critical issue - Testkube CLi executed from within air-gapped cluster was failing, as it was not able to reach GitHub

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner November 12, 2024 08:40
@rangoo94 rangoo94 merged commit d499ce5 into main Nov 12, 2024
19 of 20 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/avoid-checking-latest-version-in-git-for-every-testkube-cli-command branch November 12, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

@exu exu exu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rangoo94 @exu @vsukhin