Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: the WebSocket logic in the details page of the expansion center #4428

Merged
merged 10 commits into from
Jan 14, 2025
Merged

refactor: the WebSocket logic in the details page of the expansion center #4428

merged 10 commits into from
Jan 14, 2025

Conversation

donniean
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it

Before:

  1. Both Extension and WebSocket have WebSocket.
  2. Extension and WebSocket will establish a new WebSocket connection based on changes in resourceVersion.

After:

  1. Cancel the WebSocket connection of Extension, keeping only the WebSocket connection of InstallPlan.
  2. InstallPlan's WebSocket only connects 1, and does not establish a new WebSocket connection based on changes in resourceVersion.
  3. If there is no resourceVersion, the WebSocket parameters of InstallPlan will not include resourceVersion; if there is a resourceVersion, the WebSocket parameters of InstallPlan will include the resourceVersion from the first HTTP response.

Which issue(s) this PR fixes

Links

https://github.com/kubesphere/project/issues/5458

https://github.com/kubesphere/project/issues/5419#issuecomment-2588897224

Special notes for reviewers

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc

@donniean
feat: enhance ExtensionsManagementDetail with improved install plan h…
3d58c2b 
…andling and state management

Signed-off-by: donniean <donniean1@gmail.com>
@donniean
refactor: optimize install plan handling and reduce debounce wait time
275e998 
Signed-off-by: donniean <donniean1@gmail.com>
@donniean
refactor: remove unused resourceVersion from onSuccess callback in Ex…
62ad548 
…tensionsManagementDetail

Signed-off-by: donniean <donniean1@gmail.com>
@donniean
feat: add console log for formattedInstallPlan statusState in Extensi…
5257527 
…onsManagementDetail

Signed-off-by: donniean <donniean1@gmail.com>
@donniean
refactor: use useRef for formattedInstallPlan to maintain current sta…
79f864b 
…tusState in ExtensionsManagementDetail

Signed-off-by: donniean <donniean1@gmail.com>
@donniean
refactor: remove unused FormattedInstallPlan type import in Extension…
43bb5e4 
…sManagementDetail

Signed-off-by: donniean <donniean1@gmail.com>
@donniean
refactor: update debounce wait time to 1000ms and enhance status stat…
d3e0f9b 
…e handling in ExtensionsManagementDetail

Signed-off-by: donniean <donniean1@gmail.com>
@donniean
refactor: remove unused ExtensionStatusState import and simplify stat…
df4d3dc 
…us state check in ExtensionsManagementDetail

Signed-off-by: donniean <donniean1@gmail.com>
@ks-ci-bot ks-ci-bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2025
@donniean
Copy link
Contributor Author

/cherry-pick master

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2025
@ks-ci-bot
Copy link
Collaborator

@donniean: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donniean
refactor: remove useless useWatchExtension
243f4a1 
Signed-off-by: donniean <donniean1@gmail.com>
@donniean
refactor: remove unnecessary blank lines in ExtensionsManagementDetail
f81e41c 
Signed-off-by: donniean <donniean1@gmail.com>
@donniean
Copy link
Contributor Author

/cc @yazhouio

@ks-ci-bot ks-ci-bot requested a review from yazhouio January 14, 2025 06:15
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yazhouio
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: c398eb3876ed57521d33dd754d12375489cb2470

@ks-ci-bot ks-ci-bot merged commit 8987f27 into kubesphere:release-4.1 Jan 14, 2025
3 checks passed
@ks-ci-bot
Copy link
Collaborator

@donniean: new pull request created: #4429

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot mentioned this pull request Jan 14, 2025
Merged
@donniean donniean deleted the release-4.1 branch January 14, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yazhouio yazhouio yazhouio approved these changes

Assignees

@yazhouio yazhouio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donniean @ks-ci-bot @yazhouio