MTV-1645 Change default network annotation. #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importer pod can get stuck creating if the wrong annotation is set. Signed-off-by: Matthew Arnold <marnold@redhat.com>
|
/ok-to-test |
yaacov
approved these changes
Nov 11, 2024
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
==========================================
- Coverage 15.71% 15.66% -0.05%
==========================================
Files 112 112
Lines 23052 23052
==========================================
- Hits 3623 3612 -11
- Misses 19142 19155 +13
+ Partials 287 285 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yaacov
reviewed
Nov 11, 2024
Signed-off-by: Matthew Arnold <marnold@redhat.com>
|
|
/ok-to-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The importer pod can get stuck creating if there are multiple networks and the wrong default network override annotation is configured. This changes the annotation as requested in MTV-1645.
I reproduced the bug without the change, and managed a successful transfer with the change applied.