feat: Add the 2 new supported v2/verify payloads
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for silly-bunny-8cedd0 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Marking as draft until the dependencies have landed. |
divya-mohan0209
approved these changes
Jul 5, 2022
viccuad
force-pushed
the
new-verification-req
branch
from
a421edb
to
0a4b4f4
Compare
|
Updated to match changes in kubewarden/policy-evaluator#152. |
viccuad
changed the title
v1/verify payloadsv2/verify payloads
|
@viccuad I think the JSON objects you added are missing a special field used by serde to keep track of the type of enum that is being represented... 🤔 |
|
@flavio which fields are missing? JSON objects looks good to me. I've used these objects like those for testing the verify-image-signatures policy |
viccuad
force-pushed
the
new-verification-req
branch
from
0a4b4f4
to
d606b80
Compare
|
this is ready for another review, with the latest changes in the callback payloads. |
raulcabello
approved these changes
Jul 12, 2022
jvanz
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix kubewarden/policy-sdk-rust#40
Fix kubewarden/policy-sdk-rust#41
Test
Locally. See also on the automated build.