Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the sources usage on PolicyServer CRs #435

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Aug 7, 2024

Description

Test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
@viccuad viccuad requested a review from a team as a code owner August 7, 2024 14:59
@viccuad viccuad self-assigned this Aug 7, 2024
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for silly-bunny-8cedd0 ready!

Name Link
🔨 Latest commit 3109187
🔍 Latest deploy log https://app.netlify.com/sites/silly-bunny-8cedd0/deploys/66b45f60843c930008254f88
😎 Deploy Preview https://deploy-preview-435--silly-bunny-8cedd0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor suggestions.

docs/reference/sources_yaml.md Outdated Show resolved Hide resolved
docs/reference/sources_yaml.md Outdated Show resolved Hide resolved
Co-authored-by: John Krug <john.krug@suse.com>
Signed-off-by: Flavio Castelli <flavio@castelli.me>
@flavio
Copy link
Member

flavio commented Aug 8, 2024

Thanks for the improvements to both of you!

@flavio flavio merged commit d95970b into kubewarden:main Aug 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants