feat: Support verifying GHA signatures, Url prefix subjects #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulcabello
approved these changes
Jul 4, 2022
viccuad
changed the title
raulcabello
reviewed
Jul 5, 2022
flavio
approved these changes
Jul 5, 2022
Contains needed GHA changes.
Add `verify_github_actions()`, which is called when we receive the new
`CallbackRequestType::SigstoreGithubActionsVerify{}`.
Add `verify_keyless_prefix()`, which is called when we receive the new
`CallbackRequestType::SigstoreKeylessPrefixVerify{}`.
|
rebased consuming the yet-unreleased kubewarden-sdk-rust |
raulcabello
reviewed
Jul 5, 2022
raulcabello
approved these changes
Jul 5, 2022
jvanz
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
verify_github_actions(), which is called when we receive the newCallbackRequestType::SigstoreGithubActionsVerify{}.Add
verify_keyless_prefix(), which is called when we receive the newCallbackRequestType::SigstoreKeylessPrefixVerify{}.Depends on kubewarden/policy-sdk-rust#46
Relates to kubewarden/policy-sdk-rust#40
Relates to kubewarden/policy-sdk-rust#41
Test
Additional Information
Tradeoff
Potential improvement