feat: Add callbacks for verification of GHA signatures, Url Prefix #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new API:
`pub CallbackRequestType::SigstoreGithubActionsVerify{}`
`pub fn verify_keyless_github_actions()`
Consumers of the SDK can levarage this new API call to ask for
verification of signatures done with jobs in Github Actions.
This API addition is leveraged by policy-evaluator to perform the
callbacks in the wasm host.
flavio
requested changes
Jun 24, 2022
Co-authored-by: Flavio Castelli <flavio@castelli.me>
Add new API:
`pub CallbackRequestType::SigstoreKeylessPrefixVerify{}`
`pub fn verify_keyless_prefix_match()`
Consumers of the SDK can levarage this new API call to ask for
verification of signatures where the subject needs to be a URL prefix of
the signature subject.
This API addition is leveraged by policy-evaluator to perform the
callbacks in the wasm host.
viccuad
changed the title
jvanz
approved these changes
Jul 4, 2022
raulcabello
approved these changes
Jul 4, 2022
flavio
reviewed
Jul 5, 2022
| @@ -35,6 +35,27 @@ pub enum CallbackRequestType { | |||
| /// Optional - Annotations that must have been provided by all signers when they signed the OCI artifact | |||
| annotations: Option<HashMap<String, String>>, | |||
| }, | |||
|
|
|||
| SigstoreKeylessPrefixVerify { | |||
There was a problem hiding this comment.
nitpicking, add a short description of this struct
flavio
requested changes
Jul 5, 2022
| annotations: Option<HashMap<String, String>>, | ||
| }, | ||
|
|
||
| SigstoreGithubActionsVerify { |
There was a problem hiding this comment.
nitpicking, add a short description of this struct
| @@ -62,6 +62,51 @@ pub fn verify_keyless_exact_match( | |||
| verify(req) | |||
| } | |||
|
|
|||
| /// verify sigstore signatures of an image using keyless. Here, the provided | |||
| /// subject string is streated as a URL prefix, and sanitized to a valid URL on | |||
There was a problem hiding this comment.
Suggested change
| /// subject string is streated as a URL prefix, and sanitized to a valid URL on | |
| /// subject string is treated as a URL prefix, and sanitized to a valid URL on |
| @@ -62,6 +62,51 @@ pub fn verify_keyless_exact_match( | |||
| verify(req) | |||
| } | |||
|
|
|||
| /// verify sigstore signatures of an image using keyless. Here, the provided | |||
| /// subject string is streated as a URL prefix, and sanitized to a valid URL on | |||
| /// itself by appending `\` to prevent typosquatting. Then, the provided subject | |||
There was a problem hiding this comment.
Suggested change
| /// itself by appending `\` to prevent typosquatting. Then, the provided subject | |
| /// itself by appending `/` to prevent typosquatting. Then, the provided subject |
URLs end with /, not \
|
sigh, sorry, github played games with me and didn't update the page with the new review until I clicked merge.. I will fix it in a follow-up PR, it also needs a version bump to consume on evaluator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new API:
pub CallbackRequestType::SigstoreGithubActionsVerify{}pub fn verify_keyless_github_actions()pub CallbackRequestType::SigstoreKeylessPrefixVerify{}pub fn verify_keyless_prefix_match()Consumers of the SDK can levarage this new API call to ask for
verification of signatures done with jobs in Github Actions, and to ask for
verification of signatures where the subject needs to be a URL prefix of
the signature subject, respectively.
This API addition is leveraged by policy-evaluator to perform the
callbacks in the wasm host.
Needed by #41
Needed by #40
Test
Additional Information
Tradeoff
Potential improvement