refactor: delete the handle parameter in updateStateByVictims function

kubewharf · Nov 6, 2024 · 034b107 · 034b107
1 parent 1826bef
commit 034b107
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/pkg/binder/framework/plugins/interpodaffinity/interpodaffinity.go b/pkg/binder/framework/plugins/interpodaffinity/interpodaffinity.go
@@ -70,7 +70,7 @@ func (pl *InterPodAffinity) CheckTopology(_ context.Context, cycleState *framewo
 		return framework.NewStatus(framework.Error, err.Error())
 	}
 	if commonState != nil {
-		pl.updateStateByVictims(state, pl.frameworkHandle, commonState.VictimsGroupByNode, pod)
+		pl.updateStateByVictims(state, commonState.VictimsGroupByNode, pod)
 	}
 
 	if !utils.SatisfyPodAffinity(state, nodeInfo, podLauncher) {
@@ -94,9 +94,9 @@ func New(_ runtime.Object, handle handle.BinderFrameworkHandle) (framework.Plugi
 	}, nil
 }
 
-func (pl *InterPodAffinity) updateStateByVictims(state *utils.PreFilterState, handle handle.BinderFrameworkHandle, victimsGroupByNode map[string]map[types.UID]*v1.Pod, targetPod *v1.Pod) error {
+func (pl *InterPodAffinity) updateStateByVictims(state *utils.PreFilterState, victimsGroupByNode map[string]map[types.UID]*v1.Pod, targetPod *v1.Pod) error {
 	for nodeName, victimsMap := range victimsGroupByNode {
-		nodeInfo := handle.GetNodeInfo(nodeName)
+		nodeInfo := pl.frameworkHandle.GetNodeInfo(nodeName)
 		if nodeInfo == nil {
 			continue
 		}

diff --git a/pkg/binder/framework/plugins/podtopologyspread/podtopologyspread.go b/pkg/binder/framework/plugins/podtopologyspread/podtopologyspread.go
@@ -77,7 +77,7 @@ func (pl *PodTopologySpreadCheck) CheckTopology(_ context.Context, cycleState *f
 		return framework.NewStatus(framework.Error, err.Error())
 	}
 	if commonState != nil {
-		pl.updateStateByVictims(&state, pl.frameworkHandle, commonState.VictimsGroupByNode)
+		pl.updateStateByVictims(&state, commonState.VictimsGroupByNode)
 	}
 
 	return utils.IsSatisfyPodTopologySpreadConstraints(&state, pod, nodeInfo, podLauncher)
@@ -145,9 +145,9 @@ func (pl *PodTopologySpreadCheck) getConstraints(pod *v1.Pod) ([]utils.TopologyS
 	return constraints, nil
 }
 
-func (pl *PodTopologySpreadCheck) updateStateByVictims(state *utils.PreFilterState, handle handle.BinderFrameworkHandle, victimsGroupByNode map[string]map[types.UID]*v1.Pod) error {
+func (pl *PodTopologySpreadCheck) updateStateByVictims(state *utils.PreFilterState, victimsGroupByNode map[string]map[types.UID]*v1.Pod) error {
 	for nodeName, victimsMap := range victimsGroupByNode {
-		nodeInfo := handle.GetNodeInfo(nodeName)
+		nodeInfo := pl.frameworkHandle.GetNodeInfo(nodeName)
 		if nodeInfo == nil {
 			continue
 		}