Skip to content

Commit

Permalink
fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
@limhawjia
limhawjia committed Jul 12, 2023
1 parent 6b42342 commit 032cc43
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion pkg/util/informermanager/federatedinformermanager.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func (m *federatedInformerManager) processCluster(
// This might occur if a cluster was deleted and recreated with different connection details within a short
// period of time and we missed processing the deletion. We simply process the cluster deletion and
// reenqueue.
// Note: updating of cluster connetion details, however, is still not a supported use case.
// Note: updating of cluster connection details, however, is still not a supported use case.
err := m.processClusterDeletionUnlocked(ctx, clusterName)
return err, true
}
Expand Down
36 changes: 18 additions & 18 deletions pkg/util/informermanager/federatedinformermanager_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{}
clusterHandlers := []*ClusterEventHandler{}
manager, _ := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, _ := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that the clients for each cluster is eventually available

Expand Down Expand Up @@ -75,7 +75,7 @@ func TestFederatedInformerManager(t *testing.T) {
defaultClusters := []*fedcorev1a1.FederatedCluster{}
generators := []*EventHandlerGenerator{}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that client for cluster-1 does is not available initially.

Expand Down Expand Up @@ -117,9 +117,9 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{}
clusterHandlers := []*ClusterEventHandler{}
manager, _ := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, _ := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that listers for existing FTCs and clusters are eventually avaiable
// 2. Verify that listers for existing FTCs and clusters are eventually available

for _, ftc := range defaultFTCs {
apiresource := ftc.GetSourceType()
Expand Down Expand Up @@ -172,7 +172,7 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

ftc := daemonsetFTC
apiresource := ftc.GetSourceType()
Expand Down Expand Up @@ -220,7 +220,7 @@ func TestFederatedInformerManager(t *testing.T) {
defaultClusters := []*fedcorev1a1.FederatedCluster{}
generators := []*EventHandlerGenerator{}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

cluster := getTestCluster("cluster-1")

Expand Down Expand Up @@ -296,7 +296,7 @@ func TestFederatedInformerManager(t *testing.T) {
},
}
clusterHandlers := []*ClusterEventHandler{}
manager, _ := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, _ := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify alwaysRegistered is eventually registered for all existing FTCs and clusters.

Expand Down Expand Up @@ -392,7 +392,7 @@ func TestFederatedInformerManager(t *testing.T) {
},
}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that alwaysRegistered is not registered initially for daemonset

Expand Down Expand Up @@ -484,7 +484,7 @@ func TestFederatedInformerManager(t *testing.T) {
},
}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that alwaysRegistered is not registered initially since there are no clusters

Expand Down Expand Up @@ -602,7 +602,7 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{generator}
clusterHandlers := []*ClusterEventHandler{}
_, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
_, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

for range defaultClusters {
fn := <-assertionCh
Expand Down Expand Up @@ -656,7 +656,7 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{generator}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that handler is not registered initially.

Expand Down Expand Up @@ -728,7 +728,7 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{generator}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that handler is registered initially.

Expand Down Expand Up @@ -797,7 +797,7 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{generator}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that handler is registered initially

Expand Down Expand Up @@ -859,7 +859,7 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{generator}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that handler is registered initially

Expand Down Expand Up @@ -927,7 +927,7 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{generator1, generator2}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that handler1 and handler2 is registered initially for all FTCs

Expand Down Expand Up @@ -1040,7 +1040,7 @@ func TestFederatedInformerManager(t *testing.T) {
}
generators := []*EventHandlerGenerator{generator1, generator2}
clusterHandlers := []*ClusterEventHandler{}
manager, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
manager, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Verify that handler1 and handler2 is registered initially for all FTCs and clusters

Expand Down Expand Up @@ -1164,7 +1164,7 @@ func TestFederatedInformerManager(t *testing.T) {
defaultClusters := []*fedcorev1a1.FederatedCluster{}
generators := []*EventHandlerGenerator{}
clusterHandlers := []*ClusterEventHandler{clusterHandler}
_, fedClient := boostrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)
_, fedClient := bootstrapFederatedInformerManagerWithFakeClients(g, ctx, defaultFTCs, defaultObjs, defaultClusters, generators, clusterHandlers)

// 2. Create cluster

Expand Down Expand Up @@ -1199,7 +1199,7 @@ func TestFederatedInformerManager(t *testing.T) {
})
}

func boostrapFederatedInformerManagerWithFakeClients(
func bootstrapFederatedInformerManagerWithFakeClients(
g *gomega.WithT,
ctx context.Context,
ftcs []*fedcorev1a1.FederatedTypeConfig,
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/informermanager/interface.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ type ClusterEventPredicate func(oldCluster, newCluster *fedcorev1a1.FederatedClu

// FederatedInformerManager provides an interface for controllers that need to dynamically register event handlers and
// access objects in member clusters based on FederatedTypeConfigs. FederatedInformerManager will listen to FTC events
// and maintian informers for each FTC's source type and joined member cluster.
// and maintain informers for each FTC's source type and joined member cluster.
//
// Having multiple FTCs with the same source type is not supported and may cause FederatedInformerManager to behave
// incorrectly. Updating FTC source types is also not supported and may also cause FederatedInformerManager to behave
Expand Down

0 comments on commit 032cc43

Please sign in to comment.