From d57ab810e2de520bd751239c9138e8cfc4aa8d52 Mon Sep 17 00:00:00 2001 From: shentiecheng Date: Wed, 27 Mar 2024 15:58:54 +0800 Subject: [PATCH] fix: do not need reconcile when member cluster do not have mcs api Signed-off-by: shentiecheng --- pkg/controllers/mcs/service_export_controller.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/controllers/mcs/service_export_controller.go b/pkg/controllers/mcs/service_export_controller.go index 9e88ed59..619ac886 100644 --- a/pkg/controllers/mcs/service_export_controller.go +++ b/pkg/controllers/mcs/service_export_controller.go @@ -461,8 +461,11 @@ func (c *ServiceExportController) filterEndpointSlice( svcName := eps.Labels[discoveryv1b1.LabelServiceName] seListerInterface, synced, exists := c.fedInformerManager.GetResourceListerFromFactory(common.ServiceExportGVR, key.cluster) - if !exists || !synced() { - return true, fmt.Errorf("informer of serviceExport not exists or not synced for cluster %s", key.cluster) + if !exists { + return false, nil + } + if !synced() { + return true, fmt.Errorf("informer of serviceExport not synced for cluster %s", key.cluster) } seLister, ok := seListerInterface.(cache.GenericLister)