Merge pull request #66 from SOF3/aggregator-not-parallel

test(aggregator): avoid klog data race in unit tests
kubewharf · Jan 8, 2025 · 7b17553 · 7b17553
2 parents cf35382 + f74243a
commit 7b17553
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/aggregator/aggregator/controller_test.go b/aggregator/aggregator/controller_test.go
@@ -46,9 +46,8 @@ import (
 	"github.com/kubewharf/podseidon/aggregator/synctime"
 )
 
+//nolint:paralleltest // klog InitFlags cannot be called in parallel
 func TestReconcileEmpty(t *testing.T) {
-	t.Parallel()
-
 	testReconcile(t, TestCase{
 		MinAvailable:    5,
 		MinReadySeconds: 0,
@@ -72,9 +71,8 @@ func TestReconcileEmpty(t *testing.T) {
 	})
 }
 
+//nolint:paralleltest // klog InitFlags cannot be called in parallel
 func TestReconcileAllAvailable(t *testing.T) {
-	t.Parallel()
-
 	testReconcile(t, TestCase{
 		MinAvailable:    5,
 		MinReadySeconds: 0,
@@ -98,9 +96,8 @@ func TestReconcileAllAvailable(t *testing.T) {
 	})
 }
 
+//nolint:paralleltest // klog InitFlags cannot be called in parallel
 func TestReconcileSomeReadyButUnavailable(t *testing.T) {
-	t.Parallel()
-
 	testReconcile(t, TestCase{
 		MinAvailable:    5,
 		MinReadySeconds: 3,