fix(gateway): MeshGateway tags validation consistent with MeshRoute t…

…ags validation Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
kumahq · Oct 21, 2024 · 57cf529 · 57cf529
1 parent 7e9382e
commit 57cf529
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/pkg/core/resources/apis/mesh/gateway_validator.go b/pkg/core/resources/apis/mesh/gateway_validator.go
@@ -26,7 +26,7 @@ func (g *MeshGatewayResource) Validate() error {
 
 	// The top-level selector is used to bind the gateway to a set
 	// of dataplanes, so the service tag must not be used here.
-	err.Add(ValidateSelector(
+	err.Add(ValidateTags(
 		validators.RootedAt("tags"),
 		g.Spec.GetTags(),
 		ValidateTagsOpts{

diff --git a/pkg/core/resources/apis/mesh/gateway_validator_test.go b/pkg/core/resources/apis/mesh/gateway_validator_test.go
@@ -166,6 +166,26 @@ conf:
     tags:
       name: https
 `),
+		ErrorCase("has tag with invalid characters",
+			validators.Violation{
+				Field:   `tags["port"]`,
+				Message: `tag value must consist of alphanumeric characters, dots, dashes and underscores`,
+			}, `
+type: MeshGateway
+name: gateway
+mesh: default
+selectors:
+  - match:
+      kuma.io/service: gateway
+tags:
+  port: http/443
+conf:
+  listeners:
+  - port: 443
+    protocol: HTTP
+    tags:
+      name: https
+`),
 
 		ErrorCase("doesn't have a configuration spec",
 			validators.Violation{