Skip to content

Commit

Permalink
fix(dev/tools): fail make dev/tools step if installing go deps return…
Browse files Browse the repository at this point in the history
…ed error (backport of #11703) (#11708)

* fix(dev/tools): fail make dev/tools step if installing go deps returned error (#11703)

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>

---------


Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: Marcin Skalski <skalskimarcin33@gmail.com>
  • Loading branch information
3 people authored Oct 8, 2024
1 parent 2a69fe2 commit 9e2c565
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion mk/dependencies/deps.lock
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0df6ececa47529d52f614fb447d03b9ac4587408
8833e8be9eeeee4903952db5e738daf19645c938
8 changes: 7 additions & 1 deletion mk/dependencies/go-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ OUTPUT_PROTO_DIR=$1/protos

PGV=github.com/envoyproxy/protoc-gen-validate@$(go list -f '{{.Version}}' -m github.com/envoyproxy/protoc-gen-validate)
PGKUMADOC=github.com/kumahq/protoc-gen-kumadoc@$(go list -f '{{.Version}}' -m github.com/kumahq/protoc-gen-kumadoc)

PIDS=()
for i in \
google.golang.org/protobuf/cmd/protoc-gen-go@v1.28.1 \
google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.1.0 \
Expand All @@ -24,8 +26,12 @@ for i in \
; do
echo "install go dep: ${i}"
GOBIN=${OUTPUT_BIN_DIR} go install "${i}" &
PIDS+=($!)
done

for PID in "${PIDS[@]}"; do
wait "${PID}"
done
wait

set +x
# Get the protos from some go dependencies
Expand Down

0 comments on commit 9e2c565

Please sign in to comment.