Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s): add possibility to not add owner reference #9794

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Apr 3, 2024

Introduce a new config flag to not add ownerReference to resources.

This is useful when using argoCD which will refuse deleting resources if they have an ownerReference

Fix #9541

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Introduce a new config flag to not add ownerReference to resources.

This is useful when using argoCD which will refuse deleting resources
if they have an ownerReference

Fix kumahq#9541

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner April 3, 2024 08:54
@lahabana lahabana requested review from slonka, jakubdyszkiewicz and lobkovilya and removed request for a team April 3, 2024 08:54
Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana merged commit d029597 into kumahq:master Apr 4, 2024
15 checks passed
@lahabana lahabana deleted the fix9541 branch April 4, 2024 07:41
@lahabana lahabana changed the title feat(kubernetes): add possibility to not add owner reference feat(k8s): add possibility to not add owner reference Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OwnerReference on Mesh owned entities prevents policies to be deleted by Argo
2 participants