update module

README.md

@@ -24,16 +24,15 @@ module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
 
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name,
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name,
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG.
   # RG name must follow Azure naming convention.
   # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
-  create_resource_group = false
-  resource_group_name   = "rg-demo-internal-shared-westeurope-002"
-  location              = "westeurope"
-  storage_account_name  = "mydefaultstorage"
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
+  resource_group_name  = "rg-demo-internal-shared-westeurope-002"
+  location             = "westeurope"
+  storage_account_name = "mydefaultstorage"
 
   # To enable advanced threat protection set argument to `true`
   enable_advanced_threat_protection = true

examples/README.md

@@ -11,16 +11,15 @@ module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
 
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name,
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name,
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG.
   # RG name must follow Azure naming convention.
   # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
-  create_resource_group = false
-  resource_group_name   = "rg-demo-internal-shared-westeurope-002"
-  location              = "westeurope"
-  storage_account_name  = "mydefaultstorage"
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
+  resource_group_name  = "rg-demo-internal-shared-westeurope-002"
+  location             = "westeurope"
+  storage_account_name = "mydefaultstorage"
 
   # To enable advanced threat protection set argument to `true`
   enable_advanced_threat_protection = true
@@ -41,7 +40,6 @@ module "storage" {
     ServiceClass = "Gold"
   }
 }
-
 ```
 
 ### Storage account with SMB File Shares
@@ -51,16 +49,15 @@ module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
 
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name,
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name,
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG.
   # RG name must follow Azure naming convention.
   # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
-  create_resource_group = false
-  resource_group_name   = "rg-demo-internal-shared-westeurope-002"
-  location              = "westeurope"
-  storage_account_name  = "mydefaultstorage"
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
+  resource_group_name  = "rg-demo-internal-shared-westeurope-002"
+  location             = "westeurope"
+  storage_account_name = "mydefaultstorage"
 
   # To enable advanced threat protection set argument to `true`
   enable_advanced_threat_protection = true
@@ -90,16 +87,15 @@ module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
 
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name,
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name,
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG.
   # RG name must follow Azure naming convention.
   # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
-  create_resource_group = false
-  resource_group_name   = "rg-demo-internal-shared-westeurope-002"
-  location              = "westeurope"
-  storage_account_name  = "mydefaultstorage"
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
+  resource_group_name  = "rg-demo-internal-shared-westeurope-002"
+  location             = "westeurope"
+  storage_account_name = "mydefaultstorage"
 
   # To enable advanced threat protection set argument to `true`
   enable_advanced_threat_protection = true

examples/complete/README.md

@@ -7,16 +7,15 @@ module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
 
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name,
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name,
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG.
   # RG name must follow Azure naming convention.
   # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
-  create_resource_group = false
-  resource_group_name   = "rg-demo-internal-shared-westeurope-002"
-  location              = "westeurope"
-  storage_account_name  = "mydefaultstorage"
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
+  resource_group_name  = "rg-demo-internal-shared-westeurope-002"
+  location             = "westeurope"
+  storage_account_name = "mydefaultstorage"
 
   # To enable advanced threat protection set argument to `true`
   enable_advanced_threat_protection = true

examples/complete/main.tf

@@ -2,11 +2,12 @@ module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
 
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name, 
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name, 
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG. 
-  # RG name must follow Azure naming convention. ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
+  # RG name must follow Azure naming convention. 
+  # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
   resource_group_name  = "rg-demo-internal-shared-westeurope-002"
   location             = "westeurope"
   storage_account_name = "mydefaultstorage"

examples/storage_account_with_containers/README.md

@@ -8,32 +8,26 @@ Simple configuration to create a Azure storage account with Containers.
 module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
-  
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name,
+
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name,
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG.
   # RG name must follow Azure naming convention.
   # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
-  create_resource_group = false
-  resource_group_name   = "rg-demo-internal-shared-westeurope-002"
-  location              = "westeurope"
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
+  resource_group_name  = "rg-demo-internal-shared-westeurope-002"
+  location             = "westeurope"
+  storage_account_name = "mydefaultstorage"
 
   # To enable advanced threat protection set argument to `true`
   enable_advanced_threat_protection = true
 
-  # (Required) Project_Name, Subscription_type and environment are must to create resource names.
-  project_name      = "tieto-internal"
-  subscription_type = "shared"
-  environment       = "dev"
-
   # Container lists with access_type to create
   containers_list = [
     { name = "mystore250", access_type = "private" },
     { name = "blobstore251", access_type = "blob" },
     { name = "containter252", access_type = "container" }
   ]
-
   # Adding TAG's to your Azure resources (Required)
   # ProjectName and Env are already declared above, to use them here, create a varible.
   tags = {

examples/storage_account_with_containers/main.tf

@@ -2,16 +2,15 @@ module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
 
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name, 
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name, 
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG. 
   # RG name must follow Azure naming convention. 
   # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
-  create_resource_group = false
-  resource_group_name   = "rg-demo-internal-shared-westeurope-002"
-  location              = "westeurope"
-  storage_account_name  = "mydefaultstorage"
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
+  resource_group_name  = "rg-demo-internal-shared-westeurope-002"
+  location             = "westeurope"
+  storage_account_name = "mydefaultstorage"
 
   # To enable advanced threat protection set argument to `true`
   enable_advanced_threat_protection = true

examples/storage_account_with_fileshares/README.md

@@ -9,16 +9,15 @@ module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
 
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name,
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name,
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG.
   # RG name must follow Azure naming convention.
   # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
-  create_resource_group = false
-  resource_group_name   = "rg-demo-internal-shared-westeurope-002"
-  location              = "westeurope"
-  storage_account_name  = "mydefaultstorage"
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
+  resource_group_name  = "rg-demo-internal-shared-westeurope-002"
+  location             = "westeurope"
+  storage_account_name = "mydefaultstorage"
 
   # To enable advanced threat protection set argument to `true`
   enable_advanced_threat_protection = true

examples/storage_account_with_fileshares/main.tf

@@ -2,16 +2,15 @@ module "storage" {
   source  = "kumarvna/storage/azurerm"
   version = "2.0.0"
 
-  # By default, this module will create a resource group, proivde the name here
-  # to use an existing resource group, specify the existing resource group name, 
+  # By default, this module will not create a resource group
+  # proivde a name to use an existing resource group, specify the existing resource group name, 
   # and set the argument to `create_resource_group = false`. Location will be same as existing RG. 
   # RG name must follow Azure naming convention. 
   # For ex.: rg-<App or project name>-<Subscription type>-<Region>-<###>
-  # Resource group is named like this: rg-tieto-internal-prod-westeurope-001
-  create_resource_group = false
-  resource_group_name   = "rg-demo-internal-shared-westeurope-002"
-  location              = "westeurope"
-  storage_account_name  = "mydefaultstorage"
+  # Resource group is named like this: rg-demo-internal-prod-westeurope-001
+  resource_group_name  = "rg-demo-internal-shared-westeurope-002"
+  location             = "westeurope"
+  storage_account_name = "mydefaultstorage"
 
   # To enable advanced threat protection set argument to `true`
   enable_advanced_threat_protection = true