Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce collections interfaces #34

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

hugo-goncalves-kununu
Copy link
Collaborator

Description

The objective of this PR is to introduce interfaces to define methods for the collections (regular and filtered).

Details

  • Define interfaces for collections
  • Create FromIterable interface
  • Change AbstractCollection and AbstractFilterableCollection to implement the interfaces
  • Allow duplicates to return only unique values
  • Add keys and values method to collections
  • Fix tests
  • Add tests for new code
  • Update documentation

This PR also cherry-picked #32 and #33 that introduce the has and duplicates methods on the collections (Thanks @tdashton)

tdashton and others added 3 commits July 15, 2024 11:47
…n_array function, unit test it and update the docs.
Create FromIterable interface

Change AbstractCollection and AbstractFilterableCollection to implement the interfaces

Allow `duplicates` to remove only unique values

Add `keys` and `values` method to collections

Fix tests

Add tests for new code

Update documentation
Copy link

sonarcloud bot commented Jul 15, 2024

@hugo-goncalves-kununu hugo-goncalves-kununu merged commit 4360b71 into master Jul 15, 2024
9 checks passed
@hugo-goncalves-kununu hugo-goncalves-kununu deleted the introduce_collections_interfaces branch July 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants