Fix some bugs #22
Closed
Fix some bugs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JustAlittleWolf
commented
Jul 3, 2023
•
JustAlittleWolf
commented
- Fix 1GB per second allocated memory issue
- Update unimined from 0.4.10-snapshot to 0.4.10
- Cache SimpleDateFormat for a slight memory improvement
- Cache DecimalFormat for slight memory improvement
- Add org.gradle.toolchains.foojay-resolver-convention as plugin to resolve automatic toolchain downloads (now downloads java8 on a clean setup)
- Fix github workflows to produce artifacts again + removed deprecation warnings
- updated mod dependencies (not sure if updating fasterxml will cause issues, has not been a problem for me so far)
|
Just for future notice - please do not make your pull request change anything more than it was made for (here, mcmod.info file changes etc. instead of just fixing the memory issue) |
Idk how to continue coding without doing that tho haha |
Not sure if fasterxml will cause issues, has not been a problem for me so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.