update #1
Open
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
* Allow for `get_hardware_id()` to be used for serial number. * Length checks. * Explain length. * Cleanup. * Preprocessor magic. * Use the force, Batman. * Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it. * Cleanup. * Cleanup.
* Default OS_DETECTION_DEBOUNCE bumped from 200ms to 250ms * Add OS_DETECTION_SINGLE_REPORT to prevent undesired multiple reports * Prevents random stability issues on ARM MacBooks after switching via KVM * Works for every device I could test, including ARM MacBooks * Disabled by default to keep current behavior * Add Troubleshooting section on documentation * Tweak reset logic to prevent a freeze with some KVMs The USB stack on ARM MacBooks is more similar to that of iOS and, for some reason, it seems to like sending packets that influence the OS detection and results in a second OS_MACOS report being sent at a random period of time after plugging the keyboard back. This does not always happen and the consequences of this vary based on what the user is doing in the callback, but since this is not obvious and it's hard to debug, I've decided to add a flag for those affected by such issue. The stability issue I had in mine was a combination of factors and I found the actual cause being my own bad math when changing the default layer, but this change alone is also confirmed to fix it. Lastly, soem KVMs seem to leave the USB controlled in a suspended state when cold-booting Windows, meaning the keyboard would hang and the reset logic would not work. This tunes it so that it can get out of such state. Also retested for compatibility with my old KVM to ensure the logic works for both.
…rix to led index lookup table. (#24293) update g_led_config on hotdox76v2/hotdox76v2.c Co-authored-by: rahanahu <ra87who@gmail.com>
* Use EE_HANDS https://docs.qmk.fm/features/split_keyboard#handedness-by-eeprom * Update Janus readme to indicate EEPROM handedness is used
… keyboard modules (#24248) These are probably compatible with the Wheelwriter 1000 as well.
* [Keyboard] Corne rev4 * Remove unneeded update interval and moved split pin to dd * Cleanup config and errors * Move bootmagic config to dd * Re-add existing configs * Additional config fixes * shove off via keymap
* Added a cleaned-up set of files for ThumbsUp! v9. * Renamed the keymap for v9 as default * Update keyboards/thumbsup/keymaps/default/keymap.c As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/thumbsup/keymaps/default/keymap.c As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/thumbsup/keymaps/default/keymap.c As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/thumbsup/keymaps/default/keymap.c As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/thumbsup/keymaps/default/keymap.c As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/thumbsup/rev9_promicro_4x12/info.json As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/thumbsup/rev9_promicro_4x12/readme.md As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/thumbsup/rev9_promicro_4x12/readme.md As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/thumbsup/rev9_promicro_4x12/rules.mk As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/thumbsup/rev9_promicro_4x12/info.json As per PR review suggestions. Co-authored-by: jack <0x6a73@protonmail.com> * Apply suggestions from code review Co-authored-by: jack <0x6a73@protonmail.com> * Delete keyboards/thumbsup/keymaps/default/readme.md as per review recommendation. * v9: Fixed the layout name in keymap.c file. * v9: PR recommendatios applied - rules.mk file removed, info.json renamed to keyboard.json. * v9: PR recommendatios applied - rules.mk file removed, info.json renamed to keyboard.json. * v9: Fixed the copyright header modified by mistake. * v9: Fixed the tri-layer switch as per the review recommendation. * v9: Fixed the copyright header modified by mistake. --------- Co-authored-by: jack <0x6a73@protonmail.com>
extended wheel reports
* first compiled, flashed, and tested version of jris65 * adding readmes for mykeyclub and jris65 * removed commented out code and unneeded files * typo in build instructions * renamed info.json to keyboard.json as per new standard * formatted with qmk format-json * fixed layout offset problem * moved some settings from c/h files to json * moved matrix from .h file to .json * cleaned up non-json options * moved settings from rules.mk to keyboard.json * fix for via after removing .h file * converted keymap.c to keymap.json * keymap.c has been replaced by keymap.json * FN+Backspace loads bootload * added custom keymap for Sean * config.h setting is only needed by via * formatted json * convert via keymap from .c .h .mk to keymap.json * moved keyboard configuration to hotswap dir; note in readme that only hotswap has been tested * Update keyboards/mykeyclub/jris65/keymaps/default/keymap.json Co-authored-by: jack <jack@pngu.org> * typo Co-authored-by: jack <jack@pngu.org> * blank layers do not need to be specified Co-authored-by: jack <jack@pngu.org> * added other valid layouts Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * added other valid layouts Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * added other valid layouts Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * added other valid layouts Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * removed extra newline Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * cleaned up wording in readme Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * QMK no longer supports user keymaps * remove settings that are already the default (false settings) Co-authored-by: jack <jack@pngu.org> * add image Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * add missing commas (formatting) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * add missing commas (formatting) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * add missing commas (formatting) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * re-added second layer with QK_BOOT for backspace * make the hotswap the default keyboard * added keyboard director prefix to DEFAULT_FOLDER * ran qmk format-json on keyboard.json * DEFAULT_FOLDER option is going away so don't use it * removed via keymap as they now reside in qmk_userspace_via --------- Co-authored-by: jack <jack@pngu.org> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
* Fix Caps Lock indication * User LED state function override added Co-authored-by: Drashna Jaelre <drashna@live.com> * Change backlight enabled check and remove backlight headers Co-authored-by: Drashna Jaelre <drashna@live.com> --------- Co-authored-by: Drashna Jaelre <drashna@live.com>
Fix indicator code Co-authored-by: yiancar <yiancar@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: jack <jack@pngu.org> Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: chalex <alejandrelee+magbogbro@gmail.com>
* Somei70 addition * Changes made, added VIA keymap, cleaned formatting * keymap via * Create rules.mk * Add files via upload * Delete keyboards/somei70/keymaps/via directory * Fixed RGB and matrix * Layout corrections and LED positions * removal of rules.mk * Moved OLED Settings to somei70.c, formatted C removed TABs, removed _LAYERC * Forgot to include license header * Further changes as per suggestions, replaced _user for _kb within somei70.c * Updated keymap 'changes in Nov24' * Requested changes
Theme fix.
Co-authored-by: jack <jack@pngu.org>
Regenerate Files
* add handwired/dactyl_manuform/5x8 config
* add keymap scheme
* Update keymap.c
* Update keyboard.json
* Update keyboard.json
* fix and compile worked configs
* Update readme.md
* Update readme.md
* Update readme.md
* add dynamic macros support
* change key sets on first workday/add right2left layer
* Update keyboard.json
* Update keymap.c
* move license header to top keymap.c
* Update keyboard.json
* I rewrote the layout so that the halves are not stacked.
* I rewrote the layout so that the halves are not stacked (keymap.c)
* change "serial pin" syntactic
change
"soft_serial_pin": "D0"
to
"serial": {
"pin": "D0"
}
* fix KC_BSPC and KC_SPC on right keyboard
* Update readme.md
* Update keymap.c
Co-authored-by: Drashna Jaelre <drashna@live.com>
* Update keymap.c
Co-authored-by: Drashna Jaelre <drashna@live.com>
---------
Co-authored-by: skandiPC <slinkinfs@yandex.ru>
Co-authored-by: iliorik-ph <140731596+iliorik-ph@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <jack@pngu.org>
* Fixed SPI can't compiled issue * Added solenoid support and use 256KB ldscript for Onekey board
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com>
Add #define EE_HANDS
Co-authored-by: Ryan <fauxpark@gmail.com>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist