Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python2.6 format fields #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

juliusliunz
Copy link

I fixed the bug #40 by specifying the positional arguments for all occurrences of *.format(.
Also replaced the %s placeholder with {0} in line 204.

@kwoodson
Copy link
Owner

@juliusliunz, please let me know if this is still required. I updated the module to encompass this work. If not, please update and we'll get it merged.

@tdmalone
Copy link
Contributor

Just including my comment from #40 here, as it is closed and might not be seen:

@kwoodson Ok I tried some monkey patching of my local copy of the role - it looks like these two changes are missing:

https://github.com/kwoodson/ansible-role-yedit/pull/41/files#diff-1247c9a5559be75581ce8356c0e51c58L204 (lines 204 & 205)

After patching those, I'm able to run this on a CentOS6 server with Python 2.6.6, without the zero length field name in format error.

So that would imply that most of @kwoodson's updates to the module have fixed the Python 2.6 issue, with the exception of those two lines from this PR, which would still need to be applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants