Set 'value' type to noop validator #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the type of an argument is not set, ansible defaults to treating it as a string. As such it gets run through a validator that converts the value to a string via str(). In the case of 'value' being `null`, or perhaps a dict or list that contained `null`, the conversion via str() would cause the python native `None` to be passed to this module, which when parsed through yaml.safe_load() in parse_value(), would return the string `'None'`. To fix this, we set the type of 'value' to a noop validator, as the type may vary and we don't want ansible to perform any conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type of an argument is not set, ansible defaults to treating it
as a string. As such it gets run through a validator that converts the
value to a string via str().
In the case of 'value' being
null, or perhaps a dict or list thatcontained
null, the conversion via str() would cause the python nativeNoneto be passed to this module, which when parsed throughyaml.safe_load() in parse_value(), would return the string
'None'.To fix this, we set the type of 'value' to a noop validator, as the type
may vary and we don't want ansible to perform any conversion.