Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the display logic to display-buffer #61

Open
Fuco1 opened this issue Jan 7, 2019 · 0 comments
Open

Switch the display logic to display-buffer #61

Fuco1 opened this issue Jan 7, 2019 · 0 comments

Comments

@Fuco1
Copy link
Collaborator

Fuco1 commented Jan 7, 2019

I think rolling our own is not the correct way to integrate with the rest of Emacs. There are packages out there to manage window layout (such as the amazing shackle) which won't work with this package because it bypasses the display-buffer logic.

I think I can make it such that it behaves the same as now or very closely but using display-buffer internally. This allows users to either use some other package to manage the layout or write their own rules in display-buffer-alist.

For example, I would like the popped buffer to take over the selected window, but I don't see an option for it currently. But I can write a simple rule for display-buffer-alist to do that. This way users can customize the look&feel without shell-pop-el needing to add all the different switches.

@kyagi @syohex as you two seem to be most active here, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant