Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this actually working? #41

Closed
fblgit opened this issue Mar 10, 2024 · 11 comments
Closed

is this actually working? #41

fblgit opened this issue Mar 10, 2024 · 11 comments
Assignees

Comments

@fblgit
Copy link

fblgit commented Mar 10, 2024

did anyone made this to work?

i tested half dozen of models.. none of them actually worked.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@kyegomez
Copy link
Owner

@fblgit what does this mean? Can you elaborate?

@fblgit
Copy link
Author

fblgit commented Mar 11, 2024

i couldnt get many of the models around to work, did u manage to get this to train and do inference properly? or this is some experimental non-working code/experiment/test/poc?

@Ronsor
Copy link

Ronsor commented Mar 13, 2024

did anyone made this to work?

i tested half dozen of models.. none of them actually worked.

No, this code does not work.

@dmarx
Copy link

dmarx commented Mar 13, 2024

Do any of this user's repositories?

@kyegomez
Copy link
Owner

i couldnt get many of the models around to work, did u manage to get this to train and do inference properly? or this is some experimental non-working code/experiment/test/poc?

what code did you run, give me errors, or the output.

Also you need to finetune the model before this works so you know.

@kyegomez
Copy link
Owner

did anyone made this to work?
i tested half dozen of models.. none of them actually worked.

No, this code does not work.

do you have an error? please post the error

@kyegomez
Copy link
Owner

Do any of this user's repositories?

what error do you have exactly?

@suzuke
Copy link

suzuke commented Mar 16, 2024

The implementation of this binear is completely wrong, not only does it not follow the process outlined in the Bitnet paper, but it also misunderstands all the computational principles. I don't understand why it still receives so many stars.

@suzuke
Copy link

suzuke commented Mar 16, 2024

The issues I mentioned have been addressed in the commit 6cdb2ea.

@kyegomez
Copy link
Owner

@suzuke if it's wrong please submit a pull request

Repository owner deleted a comment from linux-leo Apr 24, 2024
Copy link

Stale issue message

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants