Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NoneType in sequential module in bit_ffn #43

Closed
jayUyang opened this issue Mar 10, 2024 · 1 comment
Closed

[BUG] NoneType in sequential module in bit_ffn #43

jayUyang opened this issue Mar 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working no-issue-activity

Comments

@jayUyang
Copy link

jayUyang commented Mar 10, 2024

self.ff sequential modules could have None, which is not callable, if post_act_ln is False.

[suggenstion]

    ff_layers = [project_in]
    if post_act_ln:
        ff_layers.append(nn.LayerNorm(inner_dim))
    ff_layers.append(nn.Dropout(dropout))
    ff_layers.append(BitLinear(inner_dim, dim_out, bias=not no_bias, *args, **kwargs))
    self.ff=nn.Sequential(*ff_layers)

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@jayUyang jayUyang added the bug Something isn't working label Mar 10, 2024
Copy link

github-actions bot commented May 9, 2024

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants