Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Weight quantization sign should be the last operation #59

Closed
wants to merge 2 commits into from
Closed

Fix: Weight quantization sign should be the last operation #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c116fc
fix: correct sign operation in weight_quant
jmbrito01 Jun 27, 2024
da3e02f
fix: correct sign for new bit linear
jmbrito01 Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bitnet/bit_linear_new.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def activation_quant(x: Tensor):
def weight_quant(w: Tensor):
scale = w.abs().mean()
e = w.mean()
u = (w - e).sign() * scale
return u
u = (w - e) * scale
return u.sign()


class BitLinearNew(nn.Linear):
Expand Down
4 changes: 2 additions & 2 deletions bitnet/bitlinear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def activation_quant(x: Tensor):
def weight_quant(w: Tensor):
scale = w.abs().mean()
e = w.mean()
u = (w - e).sign() * scale
return u
u = (w - e) * scale
return u.sign()


class BitLinear(nn.Linear):
Expand Down
Loading