Finshed Lemma A24 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added BL zero proof
Moved lemmas from explicit decomp into qubit helpers to prevent cyclic dep
kylechui
reviewed
Feb 24, 2024
| @@ -1,4 +1,7 @@ | |||
| Require Import QuantumLib.Complex. | |||
| (* @Kyle: this Matrix dependency is for just 1 thing. Maybe better to rewrite the sub_mul_mod | |||
There was a problem hiding this comment.
Which Lemma(s) are needed from Matrix? It seems like you've already moved over nat_tight_bound and sub_mod_equiv
There was a problem hiding this comment.
Oh wait this is from QuantumLib.Matrix; what's the import for?
There was a problem hiding this comment.
its sub_mul_mod
There was a problem hiding this comment.
Oh I see; I feel like it's fine because we aren't introducing any potential cyclic dependency issues as we are pulling from QuantumLib, not reorganizing code in our own codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished lemma A24
Added controlled unit properties of gates in gatehelpers.
Moved more lemmas out of explicit decomps. Maybe this file should be eliminated at some point.