-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finshed Lemma A24 #29
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f520251
added proof that an abgate that is controlled unitaries is a 2 contro…
nvaishampayan517 9117bda
added acgate control to 2q control
nvaishampayan517 e93f456
added A21 version with qubit 1
nvaishampayan517 f4ad574
created general blockmatrices concept
nvaishampayan517 df72344
added definitions to proving not tens
nvaishampayan517 d6224c4
added the TR zero proof
nvaishampayan517 a668f94
proved both abgate and acgate conds for diag block
nvaishampayan517 6e2cdf8
refactoring to reduce clutter in main appendix.
nvaishampayan517 3d6bd6c
added unitary mapping to 1
nvaishampayan517 4f8edcf
progress on a24
nvaishampayan517 e239fdf
removed 1passthrough that was unneeded
nvaishampayan517 ebbb869
finished A24
nvaishampayan517 9b10a18
Merge branch 'main' of https://github.com/nvaishampayan517/2ControlVe…
nvaishampayan517 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which Lemma(s) are needed from Matrix? It seems like you've already moved over
nat_tight_bound
andsub_mod_equiv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait this is from
QuantumLib.Matrix
; what's the import for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its sub_mul_mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see; I feel like it's fine because we aren't introducing any potential cyclic dependency issues as we are pulling from QuantumLib, not reorganizing code in our own codebase.