Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DK - Christmas fix #126

Merged
merged 3 commits into from
Jun 5, 2024
Merged

DK - Christmas fix #126

merged 3 commits into from
Jun 5, 2024

Conversation

tomsommer
Copy link
Contributor

Christmas is on the 24th in Denmark

Christmas is on the 24th in Denmark
@kylekatarnls
Copy link
Owner

It's not according to https://publicholidays.dk/2024-dates/

I'm trying to find out more sources.

@kylekatarnls
Copy link
Owner

Here it is: https://en.wikipedia.org/wiki/Public_holidays_in_Denmark

And it's called Christmas Eve while Christmas still happens on the 25th

tomsommer and others added 2 commits June 5, 2024 14:26
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
@kylekatarnls
Copy link
Owner

Yup, it's relatively common to celebrate the Eve rather than Christmas itself in many places:

https://en.wikipedia.org/wiki/Christmas

observed primarily on December 25

Some regions also celebrate primarily on December 24, rather than December 25.

@kylekatarnls kylekatarnls merged commit 20f425c into kylekatarnls:master Jun 5, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants