Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create id-national.php #129

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

stephanus-tantiono
Copy link
Contributor

No description provided.

@kylekatarnls
Copy link
Owner

Hello, I see a very different list:

Here:
https://www.timeanddate.com/holidays/indonesia/2024?hol=1

And here:
https://en.wikipedia.org/wiki/Public_holidays_in_Indonesia

Can you provide your source?

Also if there are dates based on non-Gregorian calendars, we may add keywords to support them, for instance we did:
https://github.com/kylekatarnls/business-day/blob/master/src/Cmixin/Holidays/tz-national.php#L17

@stephanus-tantiono
Copy link
Contributor Author

stephanus-tantiono commented Jun 26, 2024 via email

@kylekatarnls kylekatarnls merged commit 860b1b9 into kylekatarnls:master Jun 26, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants