Created record timer for each page in seconds, using a slider beside the button to pick time #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
completes the issue in #80 |
kylemath
commented
Jan 14, 2020
| @@ -349,35 +349,35 @@ export function PageSwitcher() { | |||
| return null | |||
| case heartSpectra: | |||
| return ( | |||
| funHeartSpectra.renderRecord(recordPopChange, recordPop, status, heartSpectraSettings) | |||
| funHeartSpectra.renderRecord(recordPopChange, recordPop, status, heartSpectraSettings, setHeartSpectraSettings) | |||
There was a problem hiding this comment.
so the record button can modify settings where this is kept
kylemath
commented
Jan 14, 2020
| @@ -3,8 +3,8 @@ import { catchError, multicast } from "rxjs/operators"; | |||
|
|
|||
| import { TextContainer, Card, Stack, RangeSlider, Button, ButtonGroup, Modal } from "@shopify/polaris"; | |||
| import { saveAs } from 'file-saver'; | |||
| import { take } from "rxjs/operators"; | |||
| import { Subject } from "rxjs"; | |||
| import { take, takeUntil } from "rxjs/operators"; | |||
There was a problem hiding this comment.
takeUntil grabs until a timer is done
kylemath
commented
Jan 14, 2020
| export function renderRecord(recordPopChange, recordPop, status, Settings, recordTwoPopChange, recordTwoPop) { | ||
| export function renderRecord(recordPopChange, recordPop, status, Settings, recordTwoPopChange, recordTwoPop, setSettings) { | ||
|
|
||
| function handleSecondsToSaveRangeSliderChange(value) { |
kylemath
commented
Jan 14, 2020
| return( | ||
| <Card title={'Record ' + Settings.name +' Data'} sectioned> | ||
| <Stack> | ||
| <RangeSlider |
kylemath
commented
Jan 14, 2020
| @@ -346,9 +359,13 @@ function saveToCSV(Settings, condition) { | |||
| ); | |||
| } | |||
| }); | |||
|
|
|||
| // setup timer | |||
kylemath
commented
Jan 14, 2020
| // put selected observable object into local and start taking samples | ||
| localObservable$ = window.multicastAlpha$.pipe( | ||
| take(numSamplesToSave) | ||
| takeUntil(timer$) |
There was a problem hiding this comment.
take until timer is over
kylemath
commented
Jan 14, 2020
| @@ -3,8 +3,8 @@ import { catchError, multicast } from "rxjs/operators"; | |||
|
|
|||
There was a problem hiding this comment.
and same for the rest of the modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested on each module and works great